Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disallows unicode escape sequence in JSX #48609

Merged
merged 9 commits into from
Aug 9, 2023
Merged

chore: disallows unicode escape sequence in JSX #48609

merged 9 commits into from
Aug 9, 2023

Conversation

Jack-Works
Copy link
Contributor

close #48596

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 8, 2022
RyanCavanaugh
RyanCavanaugh requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this check in the checker instead. It's not scalable to add a parameter to parseRightSideOfDot (which is used everywhere) for this.

@Jack-Works
Copy link
Contributor Author

We should do this check in the checker instead. It's not scalable to add a parameter to parseRightSideOfDot (which is used everywhere) for this.

It require information from scanner (scanner.hasUnicodeEscape()). Is that information still available in the checker?

jakebailey
jakebailey reviewed Apr 21, 2022
View reviewed changes
src/compiler/parser.ts Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member

We should do this check in the checker instead. It's not scalable to add a parameter to parseRightSideOfDot (which is used everywhere) for this.

I checked, and that function only has a couple of call sites (but I have no doubt that it's called a lot); I think adding another required param is not too expensive here.

@jakebailey
Copy link
Member

I think you had a bad merge; there's a load of commits on this PR now that shouldn't be.

@Jack-Works Jack-Works force-pushed the disallow-unicode-escape-sequence-jsx branch from 134e4ba to 1c40ed5 Compare April 23, 2022 02:56
@Jack-Works Jack-Works force-pushed the disallow-unicode-escape-sequence-jsx branch from 1c40ed5 to 63cf201 Compare July 16, 2022 07:22
@Jack-Works
Copy link
Contributor Author

merge conflict fixed.

@RyanCavanaugh RyanCavanaugh self-requested a review July 19, 2022 21:47
@Jack-Works
Copy link
Contributor Author

rebased

@Jack-Works
Copy link
Contributor Author

ping @RyanCavanaugh

@Jack-Works Jack-Works force-pushed the disallow-unicode-escape-sequence-jsx branch 2 times, most recently from eba9910 to 9851e90 Compare January 21, 2023 05:40
@Jack-Works
Copy link
Contributor Author

hello, @RyanCavanaugh can we have this merged? it has been nearly 1 year. This is the blocker of JSX specification cleanup.

jakebailey
jakebailey reviewed Jan 23, 2023
View reviewed changes
src/compiler/parser.ts Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member

I'm not sure Ryan has had a chance to look at this, but coming back to this (a lot later), this is how I would have implemented this myself, so I think it's okay.

@jakebailey
Copy link
Member

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 4e1734a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 4e1734a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 4e1734a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 4e1734a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 4e1734a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 4e1734a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 4e1734a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/48609/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/48609/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..48609
Metric main 48609 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,693k (± 0.01%) 359,644k (± 0.01%) -49k (- 0.01%) 359,615k 359,681k
Parse Time 3.95s (± 0.94%) 3.96s (± 1.25%) +0.01s (+ 0.38%) 3.91s 4.04s
Bind Time 1.17s (± 0.35%) 1.17s (± 0.70%) +0.00s (+ 0.14%) 1.16s 1.18s
Check Time 8.85s (± 0.30%) 8.89s (± 0.55%) +0.05s (+ 0.55%) 8.82s 8.97s
Emit Time 7.58s (± 0.39%) 7.63s (± 0.69%) +0.05s (+ 0.64%) 7.57s 7.70s
Total Time 21.55s (± 0.21%) 21.66s (± 0.45%) +0.11s (+ 0.50%) 21.56s 21.77s
Compiler-Unions - node (v18.10.0, x64)
Memory used 194,467k (± 1.52%) 193,546k (± 1.18%) -921k (- 0.47%) 192,518k 198,215k
Parse Time 1.64s (± 1.86%) 1.65s (± 1.64%) +0.01s (+ 0.61%) 1.60s 1.68s
Bind Time 0.80s (± 0.69%) 0.81s (± 1.30%) +0.01s (+ 1.26%) 0.79s 0.82s
Check Time 9.68s (± 0.92%) 9.71s (± 0.63%) +0.03s (+ 0.33%) 9.64s 9.79s
Emit Time 2.79s (± 1.00%) 2.80s (± 1.00%) +0.01s (+ 0.36%) 2.77s 2.84s
Total Time 14.91s (± 0.65%) 14.97s (± 0.61%) +0.06s (+ 0.42%) 14.85s 15.06s
Monaco - node (v18.10.0, x64)
Memory used 343,978k (± 0.01%) 343,960k (± 0.01%) -18k (- 0.01%) 343,912k 344,009k
Parse Time 2.96s (± 0.89%) 2.97s (± 0.80%) +0.01s (+ 0.39%) 2.94s 3.01s
Bind Time 1.03s (± 1.17%) 1.05s (± 1.32%) +0.01s (+ 1.13%) 1.03s 1.06s
Check Time 7.29s (± 0.56%) 7.31s (± 0.48%) +0.01s (+ 0.21%) 7.25s 7.36s
Emit Time 4.35s (± 0.74%) 4.38s (± 0.78%) +0.03s (+ 0.69%) 4.34s 4.42s
Total Time 15.63s (± 0.42%) 15.70s (± 0.37%) +0.07s (+ 0.46%) 15.62s 15.79s
TFS - node (v18.10.0, x64)
Memory used 300,321k (± 0.00%) 300,333k (± 0.01%) +12k (+ 0.00%) 300,299k 300,355k
Parse Time 2.24s (± 1.24%) 2.27s (± 1.40%) +0.03s (+ 1.34%) 2.23s 2.30s
Bind Time 1.17s (± 0.88%) 1.18s (± 1.02%) +0.02s (+ 1.43%) 1.17s 1.20s
Check Time 6.90s (± 0.36%) 6.92s (± 0.48%) +0.02s (+ 0.36%) 6.89s 6.98s
Emit Time 3.93s (± 0.73%) 4.00s (± 0.66%) +0.06s (+ 1.65%) 3.95s 4.02s
Total Time 14.24s (± 0.34%) 14.37s (± 0.46%) +0.14s (+ 0.95%) 14.28s 14.46s
material-ui - node (v18.10.0, x64)
Memory used 476,721k (± 0.01%) 476,774k (± 0.01%) +53k (+ 0.01%) 476,746k 476,828k
Parse Time 3.55s (± 0.53%) 3.58s (± 0.98%) +0.03s (+ 0.94%) 3.53s 3.62s
Bind Time 0.97s (± 0.78%) 0.97s (± 0.53%) +0.01s (+ 0.52%) 0.97s 0.98s
Check Time 17.09s (± 0.28%) 17.31s (± 0.73%) +0.22s (+ 1.29%) 17.08s 17.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.61s (± 0.29%) 21.87s (± 0.52%) +0.25s (+ 1.17%) 21.65s 21.96s
xstate - node (v18.10.0, x64)
Memory used 548,654k (± 0.01%) 548,601k (± 0.02%) -52k (- 0.01%) 548,480k 548,810k
Parse Time 4.56s (± 0.33%) 4.61s (± 0.47%) +0.05s (+ 1.10%) 4.57s 4.63s
Bind Time 1.71s (± 0.86%) 1.74s (± 0.95%) +0.03s (+ 1.56%) 1.72s 1.76s
Check Time 2.74s (± 0.75%) 2.76s (± 1.15%) +0.01s (+ 0.49%) 2.73s 2.82s
Emit Time 0.08s (± 4.99%) 0.08s (± 6.19%) +0.00s (+ 2.04%) 0.08s 0.09s
Total Time 9.10s (± 0.18%) 9.19s (± 0.40%) +0.08s (+ 0.92%) 9.14s 9.23s
Angular - node (v16.17.1, x64)
Memory used 359,056k (± 0.01%) 359,047k (± 0.01%) -9k (- 0.00%) 359,020k 359,072k
Parse Time 4.19s (± 0.44%) 4.19s (± 0.46%) +0.01s (+ 0.12%) 4.16s 4.21s
Bind Time 1.22s (± 0.33%) 1.24s (± 0.68%) +0.01s (+ 1.09%) 1.23s 1.25s
Check Time 9.55s (± 0.18%) 9.60s (± 0.16%) +0.05s (+ 0.58%) 9.59s 9.63s
Emit Time 8.08s (± 0.48%) 8.13s (± 0.82%) +0.05s (+ 0.60%) 8.05s 8.22s
Total Time 23.04s (± 0.16%) 23.16s (± 0.31%) +0.12s (+ 0.54%) 23.04s 23.24s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,251k (± 0.03%) 194,271k (± 0.06%) +20k (+ 0.01%) 194,125k 194,384k
Parse Time 1.81s (± 0.45%) 1.80s (± 0.65%) -0.00s (- 0.28%) 1.78s 1.81s
Bind Time 0.84s (± 1.06%) 0.85s (± 0.48%) +0.01s (+ 0.99%) 0.84s 0.85s
Check Time 10.37s (± 0.36%) 10.40s (± 0.48%) +0.04s (+ 0.35%) 10.32s 10.45s
Emit Time 3.06s (± 0.77%) 3.05s (± 0.74%) -0.01s (- 0.44%) 3.03s 3.09s
Total Time 16.08s (± 0.19%) 16.10s (± 0.42%) +0.02s (+ 0.15%) 15.98s 16.17s
Monaco - node (v16.17.1, x64)
Memory used 343,217k (± 0.01%) 343,244k (± 0.01%) +27k (+ 0.01%) 343,206k 343,262k
Parse Time 3.14s (± 0.82%) 3.18s (± 1.30%) +0.04s (+ 1.22%) 3.13s 3.23s
Bind Time 1.11s (± 0.89%) 1.12s (± 0.46%) +0.01s (+ 0.75%) 1.11s 1.12s
Check Time 7.89s (± 0.25%) 7.94s (± 0.57%) +0.05s (+ 0.61%) 7.86s 8.00s
Emit Time 4.57s (± 0.39%) 4.58s (± 0.66%) +0.02s (+ 0.33%) 4.54s 4.62s
Total Time 16.70s (± 0.24%) 16.81s (± 0.52%) +0.11s (+ 0.67%) 16.67s 16.91s
TFS - node (v16.17.1, x64)
Memory used 299,713k (± 0.01%) 299,698k (± 0.01%) -15k (- 0.01%) 299,674k 299,742k
Parse Time 2.47s (± 1.40%) 2.48s (± 2.03%) +0.01s (+ 0.34%) 2.44s 2.57s
Bind Time 1.25s (± 0.33%) 1.26s (± 0.41%) +0.00s (+ 0.40%) 1.25s 1.26s
Check Time 7.53s (± 0.50%) 7.55s (± 0.36%) +0.02s (+ 0.22%) 7.52s 7.59s
Emit Time 4.24s (± 0.79%) 4.27s (± 0.62%) +0.02s (+ 0.59%) 4.25s 4.32s
Total Time 15.49s (± 0.38%) 15.55s (± 0.30%) +0.06s (+ 0.35%) 15.49s 15.62s
material-ui - node (v16.17.1, x64)
Memory used 476,133k (± 0.02%) 476,109k (± 0.02%) -24k (- 0.00%) 475,998k 476,181k
Parse Time 3.72s (± 0.40%) 3.73s (± 0.41%) +0.01s (+ 0.36%) 3.71s 3.75s
Bind Time 1.02s (± 0.00%) 1.02s (± 0.50%) +0.00s (+ 0.33%) 1.02s 1.03s
Check Time 18.05s (± 0.13%) 18.20s (± 0.80%) +0.16s (+ 0.87%) 18.06s 18.39s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.78s (± 0.14%) 22.96s (± 0.66%) +0.18s (+ 0.79%) 22.80s 23.14s
xstate - node (v16.17.1, x64)
Memory used 546,280k (± 0.03%) 546,312k (± 0.04%) +32k (+ 0.01%) 546,157k 546,642k
Parse Time 4.76s (± 0.57%) 4.78s (± 0.47%) +0.02s (+ 0.42%) 4.75s 4.81s
Bind Time 1.81s (± 4.15%) 1.85s (± 0.41%) +0.04s (+ 2.11%) 1.84s 1.86s
Check Time 2.98s (± 2.58%) 2.96s (± 0.46%) -0.01s (- 0.45%) 2.94s 2.98s
Emit Time 0.09s (± 4.45%) 0.10s (± 5.76%) +0.00s (+ 3.64%) 0.09s 0.10s
Total Time 9.65s (± 0.47%) 9.69s (± 0.19%) +0.04s (+ 0.45%) 9.67s 9.72s
Angular - node (v14.15.1, x64)
Memory used 352,668k (± 0.01%) 352,625k (± 0.02%) -43k (- 0.01%) 352,576k 352,708k
Parse Time 4.23s (± 0.35%) 4.27s (± 0.66%) +0.04s (+ 0.83%) 4.24s 4.31s
Bind Time 1.28s (± 0.40%) 1.29s (± 0.76%) +0.00s (+ 0.39%) 1.27s 1.30s
Check Time 9.84s (± 0.23%) 9.85s (± 0.53%) +0.01s (+ 0.12%) 9.79s 9.91s
Emit Time 8.38s (± 0.39%) 8.47s (± 0.99%) +0.10s (+ 1.17%) 8.32s 8.57s
Total Time 23.73s (± 0.15%) 23.89s (± 0.58%) +0.15s (+ 0.65%) 23.66s 24.02s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,268k (± 0.06%) 189,103k (± 0.06%) -165k (- 0.09%) 188,988k 189,311k
Parse Time 1.85s (± 0.95%) 1.85s (± 0.80%) +0.00s (+ 0.09%) 1.83s 1.87s
Bind Time 0.86s (± 0.00%) 0.87s (± 0.94%) +0.01s (+ 0.78%) 0.86s 0.88s
Check Time 10.41s (± 0.33%) 10.48s (± 0.42%) +0.08s (+ 0.74%) 10.43s 10.54s
Emit Time 3.21s (± 4.13%) 3.44s (± 4.15%) +0.22s (+ 6.95%) 3.15s 3.52s
Total Time 16.33s (± 0.91%) 16.63s (± 1.06%) +0.30s (+ 1.87%) 16.28s 16.77s
Monaco - node (v14.15.1, x64)
Memory used 337,987k (± 0.01%) 338,011k (± 0.02%) +24k (+ 0.01%) 337,956k 338,138k
Parse Time 3.22s (± 1.28%) 3.28s (± 1.97%) +0.06s (+ 1.81%) 3.23s 3.41s
Bind Time 1.12s (± 0.75%) 1.12s (± 1.08%) +0.01s (+ 0.75%) 1.11s 1.14s
Check Time 8.25s (± 0.57%) 8.31s (± 0.45%) +0.07s (+ 0.81%) 8.26s 8.35s
Emit Time 4.81s (± 0.43%) 4.85s (± 0.46%) +0.04s (+ 0.83%) 4.83s 4.89s
Total Time 17.39s (± 0.20%) 17.57s (± 0.60%) +0.18s (+ 1.02%) 17.48s 17.77s
TFS - node (v14.15.1, x64)
Memory used 294,512k (± 0.01%) 294,511k (± 0.01%) -1k (- 0.00%) 294,489k 294,533k
Parse Time 2.74s (± 0.88%) 2.76s (± 0.30%) +0.01s (+ 0.36%) 2.75s 2.77s
Bind Time 1.11s (± 0.00%) 1.12s (± 0.46%) +0.01s (+ 0.60%) 1.11s 1.12s
Check Time 7.81s (± 0.50%) 7.87s (± 0.65%) +0.05s (+ 0.68%) 7.80s 7.93s
Emit Time 4.65s (± 0.52%) 4.62s (± 0.67%) -0.04s (- 0.75%) 4.57s 4.66s
Total Time 16.32s (± 0.28%) 16.35s (± 0.33%) +0.03s (+ 0.19%) 16.30s 16.43s
material-ui - node (v14.15.1, x64)
Memory used 471,503k (± 0.00%) 471,514k (± 0.00%) +12k (+ 0.00%) 471,497k 471,534k
Parse Time 3.93s (± 0.44%) 3.96s (± 0.71%) +0.03s (+ 0.81%) 3.93s 4.01s
Bind Time 1.05s (± 0.99%) 1.05s (± 1.30%) +0.01s (+ 0.64%) 1.03s 1.07s
Check Time 19.05s (± 0.55%) 19.16s (± 0.50%) +0.11s (+ 0.59%) 19.02s 19.27s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 24.03s (± 0.54%) 24.18s (± 0.35%) +0.15s (+ 0.64%) 24.04s 24.29s
xstate - node (v14.15.1, x64)
Memory used 534,330k (± 0.01%) 534,353k (± 0.01%) +23k (+ 0.00%) 534,300k 534,421k
Parse Time 5.14s (± 0.78%) 5.21s (± 1.08%) +0.07s (+ 1.36%) 5.14s 5.28s
Bind Time 1.72s (± 0.86%) 1.73s (± 0.87%) +0.01s (+ 0.48%) 1.70s 1.74s
Check Time 3.08s (± 0.67%) 3.12s (± 0.60%) +0.03s (+ 1.03%) 3.08s 3.13s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.04s (± 0.57%) 10.15s (± 0.53%) +0.11s (+ 1.13%) 10.08s 10.20s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 48609 6
Baseline main 6

TSServer

Comparison Report - main..48609
Metric main 48609 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,533ms (± 1.54%) 2,525ms (± 1.15%) -8ms (- 0.33%) 2,483ms 2,568ms
Req 2 - geterr 5,510ms (± 0.33%) 5,570ms (± 0.53%) +60ms (+ 1.08%) 5,542ms 5,624ms
Req 3 - references 364ms (± 1.48%) 369ms (± 1.28%) +5ms (+ 1.33%) 365ms 378ms
Req 4 - navto 283ms (± 0.99%) 284ms (± 1.08%) +2ms (+ 0.65%) 280ms 287ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 68ms (± 4.41%) 68ms (± 4.76%) +0ms (+ 0.49%) 64ms 72ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,735ms (± 1.49%) 2,739ms (± 1.09%) +4ms (+ 0.14%) 2,709ms 2,785ms
Req 2 - geterr 4,043ms (± 0.47%) 4,067ms (± 0.71%) +25ms (+ 0.61%) 4,027ms 4,100ms
Req 3 - references 367ms (± 0.36%) 370ms (± 0.74%) +3ms (+ 0.86%) 368ms 375ms
Req 4 - navto 293ms (± 0.63%) 295ms (± 0.72%) +2ms (+ 0.80%) 292ms 297ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 66ms (± 0.62%) 67ms (± 0.77%) +1ms (+ 0.76%) 66ms 67ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,489ms (± 0.77%) 3,522ms (± 0.52%) +33ms (+ 0.95%) 3,487ms 3,541ms
Req 2 - geterr 1,404ms (± 1.50%) 1,410ms (± 1.56%) +6ms (+ 0.44%) 1,391ms 1,448ms
Req 3 - references 106ms (± 0.97%) 105ms (± 1.78%) -2ms (- 1.57%) 103ms 107ms
Req 4 - navto 355ms (± 0.68%) 356ms (± 0.41%) +1ms (+ 0.38%) 354ms 358ms
Req 5 - completionInfo count 3,171 (± 0.00%) 3,171 (± 0.00%) 0 ( 0.00%) 3,171 3,171
Req 5 - completionInfo 467ms (± 1.27%) 468ms (± 1.25%) +2ms (+ 0.32%) 457ms 474ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,786ms (± 0.40%) 2,792ms (± 1.03%) +6ms (+ 0.22%) 2,740ms 2,822ms
Req 2 - geterr 5,886ms (± 0.36%) 5,894ms (± 0.67%) +9ms (+ 0.14%) 5,861ms 5,969ms
Req 3 - references 379ms (± 1.03%) 378ms (± 1.14%) -1ms (- 0.35%) 373ms 385ms
Req 4 - navto 279ms (± 1.66%) 281ms (± 0.93%) +3ms (+ 0.90%) 278ms 285ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 80ms (± 9.04%) 76ms (± 8.82%) 🟩-4ms (- 4.38%) 71ms 89ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,927ms (± 0.37%) 2,948ms (± 0.68%) +21ms (+ 0.72%) 2,920ms 2,981ms
Req 2 - geterr 4,391ms (± 0.61%) 4,418ms (± 0.41%) +27ms (+ 0.62%) 4,400ms 4,450ms
Req 3 - references 383ms (± 0.71%) 382ms (± 1.06%) -1ms (- 0.30%) 377ms 389ms
Req 4 - navto 287ms (± 0.87%) 290ms (± 0.65%) +2ms (+ 0.75%) 287ms 292ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 1.14%) 72ms (± 1.17%) -0ms (- 0.23%) 71ms 73ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,642ms (± 0.45%) 3,643ms (± 0.47%) +1ms (+ 0.02%) 3,622ms 3,673ms
Req 2 - geterr 1,546ms (± 0.96%) 1,550ms (± 1.58%) +4ms (+ 0.28%) 1,507ms 1,570ms
Req 3 - references 112ms (± 1.43%) 111ms (± 1.94%) -1ms (- 0.45%) 109ms 115ms
Req 4 - navto 333ms (± 0.49%) 332ms (± 0.45%) -1ms (- 0.30%) 330ms 334ms
Req 5 - completionInfo count 3,171 (± 0.00%) 3,171 (± 0.00%) 0 ( 0.00%) 3,171 3,171
Req 5 - completionInfo 478ms (± 0.85%) 478ms (± 1.59%) -1ms (- 0.10%) 470ms 492ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,900ms (± 0.55%) 2,919ms (± 0.32%) +19ms (+ 0.66%) 2,901ms 2,927ms
Req 2 - geterr 6,271ms (± 0.67%) 6,352ms (± 1.08%) +81ms (+ 1.29%) 6,220ms 6,412ms
Req 3 - references 387ms (± 0.45%) 394ms (± 1.15%) +7ms (+ 1.76%) 391ms 403ms
Req 4 - navto 284ms (± 1.45%) 283ms (± 0.27%) -1ms (- 0.23%) 282ms 284ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 87ms (± 7.36%) 89ms (± 4.78%) +2ms (+ 1.92%) 81ms 92ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,063ms (± 0.28%) 3,080ms (± 0.45%) +17ms (+ 0.57%) 3,063ms 3,105ms
Req 2 - geterr 4,669ms (± 0.28%) 4,703ms (± 0.43%) +34ms (+ 0.74%) 4,672ms 4,731ms
Req 3 - references 413ms (± 1.46%) 412ms (± 1.54%) -1ms (- 0.12%) 405ms 422ms
Req 4 - navto 297ms (± 0.45%) 298ms (± 0.58%) +1ms (+ 0.45%) 296ms 301ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 88ms (± 0.85%) 88ms (± 0.46%) 0ms ( 0.00%) 88ms 89ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,962ms (± 0.53%) 4,001ms (± 0.55%) +39ms (+ 0.97%) 3,964ms 4,019ms
Req 2 - geterr 1,518ms (± 1.29%) 1,546ms (± 1.69%) +28ms (+ 1.86%) 1,521ms 1,575ms
Req 3 - references 133ms (± 3.36%) 132ms (± 2.58%) -1ms (- 0.38%) 128ms 136ms
Req 4 - navto 374ms (± 0.84%) 376ms (± 1.75%) +3ms (+ 0.67%) 372ms 389ms
Req 5 - completionInfo count 3,171 (± 0.00%) 3,171 (± 0.00%) 0 ( 0.00%) 3,171 3,171
Req 5 - completionInfo 504ms (± 1.39%) 503ms (± 1.58%) -1ms (- 0.26%) 494ms 517ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 48609 6
Baseline main 6

Startup

Comparison Report - main..48609
Metric main 48609 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 141.78ms (± 0.17%) 142.93ms (± 0.24%) +1.16ms (+ 0.82%) 141.84ms 147.96ms
tsserver-startup - node (v16.17.1, x64)
Execution time 225.20ms (± 0.14%) 228.68ms (± 0.40%) +3.48ms (+ 1.55%) 226.12ms 234.11ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.82ms (± 0.16%) 230.81ms (± 0.35%) +2.99ms (+ 1.31%) 227.95ms 236.66ms
typescript-startup - node (v16.17.1, x64)
Execution time 208.79ms (± 0.16%) 211.38ms (± 0.33%) +2.59ms (+ 1.24%) 209.38ms 217.98ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 48609 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/48609/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/48609/merge:

Something interesting changed - please have a look.

Details

palantir/blueprint

⚠️ Note that built also had errors ⚠️ 
Req #19321 - references
    at getContextualTypeForArgument (/typescript-main/built/local/tsserver.js:70339:40)
    at getContextualType2 (/typescript-main/built/local/tsserver.js:70783:16)
    at getApparentTypeOfContextualType (/typescript-main/built/local/tsserver.js:70719:120)
    at getContextualType2 (/typescript-main/built/local/tsserver.js:70798:22)
    at getApparentTypeOfContextualType (/typescript-main/built/local/tsserver.js:70719:120)
    at getContextualSignature (/typescript-main/built/local/tsserver.js:71086:18)
    at getNarrowedTypeOfSymbol (/typescript-main/built/local/tsserver.js:69534:39)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69626:16)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68576:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68462:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68419:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69669:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77727:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72241:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77761:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77681:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72162:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68237:22)

Req #19321 - references
    at resolveNameHelper (/typescript-48609/built/local/tsserver.js:48220:29)
    at resolveName (/typescript-48609/built/local/tsserver.js:48218:12)
    at getResolvedSymbol (/typescript-48609/built/local/tsserver.js:67462:54)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69577:20)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77745:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at checkPropertyAccessExpression (/typescript-48609/built/local/tsserver.js:72259:162)
    at checkExpressionWorker (/typescript-48609/built/local/tsserver.js:77779:16)
    at checkExpression (/typescript-48609/built/local/tsserver.js:77699:32)
    at checkNonNullExpression (/typescript-48609/built/local/tsserver.js:72180:29)
    at getEffectsSignature (/typescript-48609/built/local/tsserver.js:68255:22)
    at getTypeAtFlowCall (/typescript-48609/built/local/tsserver.js:68594:25)
    at getTypeAtFlowNode (/typescript-48609/built/local/tsserver.js:68480:18)
    at getFlowTypeOfReference (/typescript-48609/built/local/tsserver.js:68437:45)
    at checkIdentifier (/typescript-48609/built/local/tsserver.js:69687:22)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

 
{"seq":19318,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":270816}}
{"seq":19319,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":270893,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":19320,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":270893,"entryNames":["arguments"]}}
{"seq":19321,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":272121}}

Repro Steps
  1. git clone https://github.com/palantir/blueprint --recurse-submodules
  2. In dir blueprint, run git reset --hard c0db644e9dec3b97bf3c8f3b919ac8bc55d491a2
  3. In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
  4. Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

@jakebailey
Copy link
Member

I've merged main back into this to fix the conflict.

My impression from a recent discussion is that we are looking to move parse-checks out of the checker and into the parser, and I think this is an example of that.

@Jack-Works Jack-Works changed the title chore: disallows unicode escape sequence chore: disallows unicode escape sequence in JSX Jun 10, 2023
@Jack-Works
Merge branch 'main' into disallow-unicode-escape-sequence-jsx # Please
8a8838b 
enter a commit message to explain why this merge is necessary, #
especially if it merges an updated upstream into a topic branch. # # Lines
starting with '#' will be ignored, and an empty message aborts # the
commit.
@Jack-Works
Copy link
Contributor Author

cc @RyanCavanaugh can we merge this

@RyanCavanaugh RyanCavanaugh merged commit cd391b0 into microsoft:main Aug 9, 2023
18 checks passed
@Jack-Works Jack-Works deleted the disallow-unicode-escape-sequence-jsx branch August 10, 2023 02:56
@Jack-Works Jack-Works mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@RyanCavanaugh RyanCavanaugh

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow UnicodeEscapeSequence in JSX Element name
4 participants
@Jack-Works @jakebailey @typescript-bot @RyanCavanaugh